fix: deep-merge CLI agent-config with config file values - #636
Merged
dwash96 merged 1 commit intoAug 12, 2026
Conversation
dwash96
pushed a commit
that referenced
this pull request
Aug 12, 2026
Fold the agent-config deep-merge from PR #636 into convert_yaml_to_json_string(value, config_file_value=None) so --agent-config isn't parsed differently from the other yaml-to-json args. All such args (agent_config, tui_config, mcp_servers, custom, security_config, retries, hooks, workspaces, model_providers, server_config) now deep-merge with the value for their hyphenated config-file key (CLI wins per-key, file-only keys preserved; underscore-key variants unsupported). Parsing now uses json.loads first so JSON booleans/null parse correctly before falling back to ast.literal_eval for Python-literal forms.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK here is the right one (I hope). Previously based PR off of experimental branch by mistake..
Recently I had an issue adding a skill to local cecli.conf.yml - it wasn't picked up. I asked Cecli to investigate and it ended up patching itself. Apparently the way the home directory and working directory configs are parsed was not working right when certain arguments were also included - resulted in my local skill not being recognized on startup.
Please have a look and see if this might help.
What I did:
Added a new skill to local directory
What happened:
The skill was not shown in "skills"
Command in question:
cecli --agent-config '{"command_timeout": 0, "skip_cli_confirmations": true}' --model deepseek/deepseek-v4-flash --editor-model deepseek/deepseek-v4-flashMy cecli.conf.yml for reference:
Skill is android-cli (in .cecli/skills)
Notification before patch:
Notification after patch: