[Backend Config ~ Reference ~ DO NOT MERGE] move H5DataIO from add_* functions and methods to dataset configuration - #475
Closed
bendichter wants to merge 14 commits into
Closed
[Backend Config ~ Reference ~ DO NOT MERGE] move H5DataIO from add_* functions and methods to dataset configuration#475bendichter wants to merge 14 commits into
bendichter wants to merge 14 commits into
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # src/neuroconv/tools/nwb_helpers.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Comment on lines
-89
to
+78
| extracted_data = electrical_series.data[:] | ||
| extracted_data = np.vstack([x.data for x in electrical_series.data]) |
Contributor
There was a problem hiding this comment.
What was the reason for this series of changes?
Contributor
Author
There was a problem hiding this comment.
When you wrap a DataChunkIterator object in a DataIO object, you can use [:] to access the data, however if you are trying to access the data directly from a DataChunkIterator object, you need to iterate through it.
CodyCBakerPhD
changed the title
6 tasks
CodyCBakerPhD
changed the title
Contributor
|
This can at last be closed as all relevant aspects used for reference have been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to:
H5DataIOfromadd_*functions and methods. These functions and methods should now only be used to assemble the data and metadata, but should be backend-agnostic.configure_datasetsmethod toBaseDataInterfacethis PR is blocked by hdmf-dev/hdmf#868