Skip to content

Surface the search filters as controls, extract snippets in the engine, and fix the test suite on modern Node #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franciscoxc wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Surface the search filters as controls, extract snippets in the engine, and fix the test suite on modern Node #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c8eedb
fix(test): restore jsdom localStorage under Node 22+, and correct the…
franciscoxc Aug 2, 2026
30ee8b3
feat(search-cache): extract content snippets in the engine, and add t…
franciscoxc Aug 2, 2026
f3f67b5
feat(cardinal): surface the search filters as controls in the bar
franciscoxc Aug 2, 2026
d1dc2b8
build: match the tauri crate to the @tauri-apps/api the lockfile reso…
franciscoxc Aug 2, 2026
d1748ee
style: format the content-terms chain the way rustfmt wants
franciscoxc Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/frontend-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
# 22+: the test script passes --no-experimental-webstorage, which Node 20 rejects as an
# unknown option. Node 20 reached end of life in April 2026.
node-version: 24
cache: npm
cache-dependency-path: cardinal/package-lock.json

Expand Down
3 changes: 2 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
- Desktop app lives in `cardinal/` (React UI in `src/`, Tauri/native glue in `src-tauri/`, build output in `cardinal/dist/`).
- Workspace crates (root `Cargo.toml`): `lsf/` (CLI), `cardinal-sdk/` (shared types), `fswalk/`, `fs-icon/`, `namepool/`, `query-segmentation/`, `search-cache/`, `search-cancel/`, `cardinal-syntax/`, `slab-mmap/` (mmap-backed slab for the cache), `was/` (CLI that streams FSEvents via the SDK).
- Tests sit next to code; cross-crate cases belong in each crate’s `tests/` directory. Generated outputs (`target/`, `cardinal/dist/`, vendor bundles) stay out of commits.
- Toolchain pinned via `rust-toolchain.toml` (`nightly-2025-05-09`); install with `rustup toolchain install nightly-2025-05-09`.
- Toolchain pinned via `rust-toolchain.toml` (`nightly-2025-12-11`); install with `rustup toolchain install nightly-2025-12-11`. Let the rustup shim pick it up rather than putting a toolchain's `bin/` on `PATH`: an older rustc still builds here from cache, but the proc-macro dylibs it emits are rejected by recent macOS dyld with `mis-aligned LINKEDIT string pool` as soon as anything has to be rebuilt.
- Keep `target/` out of iCloud-synced folders (`CARGO_TARGET_DIR`). If iCloud evicts a fingerprint file, cargo blocks forever in `read()` waiting for a download that never lands.

## Build, Test, and Development Commands
- `cargo check --workspace` — fast compile validation for all crates.
Expand Down
16 changes: 13 additions & 3 deletions cardinal/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions cardinal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@
"build": "vite build",
"preview": "vite preview",
"tauri": "tauri",
"test": "vitest --watch=false",
"test:watch": "vitest --watch",
"test": "NODE_OPTIONS=--no-experimental-webstorage vitest --watch=false",
"test:watch": "NODE_OPTIONS=--no-experimental-webstorage vitest --watch",
"typecheck": "tsc --noEmit",
"format": "prettier --write .",
"format:check": "prettier --check ."
},
"dependencies": {
"@crabnebula/tauri-plugin-drag": "^2.1.0",
"@tauri-apps/api": "^2",
"@tauri-apps/plugin-dialog": "^2.7.2",
"@tauri-apps/plugin-global-shortcut": "^2.3.1",
"@tauri-apps/plugin-opener": "^2",
"@tauri-apps/plugin-window-state": "^2.4.1",
Expand Down
Loading
Loading