Fix memory displacement overflowing i32 on AArch64 - #203
Merged
Conversation
jiegec
approved these changes
Aug 6, 2026
For AArch64 instructions like 'LDR Xn, #imm' at addresses larger than i32::MAX the displacement overflows, producing an incorrect value. Fixed by returning i64 directly, as capstone does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For AArch64 instructions like 'LDR Xn, #imm' at addresses larger than i32::MAX the displacement overflows, producing an incorrect value. Fixed by returning i64 directly, as capstone does.
I ran into this with the following code:
Without this change 0x10000768C overflows i32, giving a displacement of 0x768c.
I created a second branch for testing which adds an extra log in cstool - capstone-v6-test, that allows running this command:
This matches the output of capstone's cstool: