test(config): unit tests and golden fixtures for the update_config migration (5/6)#188
Draft
marceloneppel wants to merge 1 commit into
Draft
test(config): unit tests and golden fixtures for the update_config migration (5/6)#188marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
This was referenced Jul 20, 2026
Open
Draft
marceloneppel
changed the title
marceloneppel
changed the title
marceloneppel
force-pushed
the
feature/migrate-update-config
branch
from
July 20, 2026 19:04
912b1a4 to
9efcc0a
Compare
marceloneppel
force-pushed
the
skl-01-update-config-tests
branch
from
July 20, 2026 19:04
808b479 to
373a525
Compare
marceloneppel
force-pushed
the
feature/migrate-update-config
branch
from
July 20, 2026 20:25
9efcc0a to
e80e84f
Compare
marceloneppel
force-pushed
the
skl-01-update-config-tests
branch
from
July 20, 2026 20:25
373a525 to
558c61f
Compare
…gration Split the migration's unit tests and patroni-template golden fixtures out of the code changes so each code change lands as a small, self-contained PR, with the tests landing together on top of the stack. Covers the peer-state config/user hash accessors, PostgreSQL parameter building and resource introspection, the substrate-conditional patroni template, and the update_config orchestration. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
force-pushed
the
feature/migrate-update-config
branch
from
July 21, 2026 17:46
e80e84f to
113b21b
Compare
marceloneppel
force-pushed
the
skl-01-update-config-tests
branch
from
July 21, 2026 17:47
558c61f to
ba946a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
update_configmigration's unit tests and patroni-template golden fixtures were bundled with the code changes, pushing each code PR in the stack past the review-size target.Solution
Split the tests out of the code PRs so each code change lands small and self-contained, with the tests landing together here on top of the code PRs. Only the minimal edits to existing tests needed to keep each code PR green stayed with the code; every new test and both golden fixtures are here.
Covers the peer-state config/user hash accessors (#181), PostgreSQL parameter building and resource introspection (#182), the substrate-conditional patroni template and its byte-identical golden render matrix (#183), and the
update_configorchestration (#180).Checklist