feat(ldap): migrate ldap lib#602
Open
natalian98 wants to merge 3 commits into
Open
Conversation
natalian98
force-pushed
the
IAM-2265-migrate-ldap-lib
branch
from
July 17, 2026 14:31
f984dd5 to
314984e
Compare
natalian98
marked this pull request as ready for review
July 17, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the
ldapinterface library from charmhub into charmlibs.Library being migrated
charmlibspackage: charmlibs.interfaces.ldapThis is an interface library (
charmlibs.interfaces.<name>,just init --interface).Migration status
This is a bug compatible migration of the Charmhub-hosted library, releasing as version 1.0.0.
Package:
just initorjust init --interface.src/charmlibs/<name>/_<name>.py.__init__.pywith__all__.__init__.py(this is rendered in the docs).LIBAPIandLIBPATCHversion documented in the migrated module's docstring.LIBID,LIBAPI,LIBPATCHremoved (or retained with a note on why).PYDEPSmoved topyproject.tomldependencieswith appropriate constraints.1.0.0).Repository metadata:
.docs/reference/libs.yamlupdated with entries for new and old libs.CODEOWNERSupdated with a/<package>/entry for the owning team.Tests and docs:
just inithave been removed (includingtest_version.pyandtests/functionalandtests/integrationif unused).<package>/docs/.Interface library specific items
charmcraft.yaml.interfaces/<name>/testing/exportingrelation_for_providerandrelation_for_requirerif needed (see how-to guide), or an issue created and tracked to do this as a follow-up task.Commit strategy
To make review easier, this PR is organized into focused, semantic commits:
• feat: migrate
ldapinterface: Unified migration of the upstream library. Contains the core scaffolding, verbatim baseline files (library source, tests, and documentation), updated imports, and linter-enforced adjustments in a single coherent step.• chore: update
ldaplib metadata: Registering the package in the monorepo's global configuration indices (interfaces/index.jsonand.docs/reference/libs.yaml).• chore: update
CODEOWNERS: Registry of monorepo code ownership for theldapinterface directory.