Skip to content

fix(auth): simplify sign-up label - #111

Merged
cameroncuster merged 1 commit into
mainfrom
cameroncuster/sign-up-label
Jul 26, 2026
Merged

fix(auth): simplify sign-up label#111
cameroncuster merged 1 commit into
mainfrom
cameroncuster/sign-up-label

Conversation

@cameroncuster

Copy link
Copy Markdown
Owner

Summary

  • rename the signed-out primary CTA from “Continue with GitHub” to “Sign up” on desktop and mobile
  • retain GitHub-specific loading and error copy because those states describe the OAuth operation
  • update auth smoke coverage for the new label

Validation

  • pnpm run lint:es
  • pnpm run check — 0 errors, 0 warnings
  • focused mocked desktop auth scenarios — 3 passed
  • focused mocked mobile auth scenarios — 3 passed

Risk

Copy-only product change. The GitHub OAuth implementation and authenticated behavior are unchanged.


Pull Request opened by Augment Code | View session

@cameroncuster
cameroncuster marked this pull request as ready for review July 26, 2026 07:12
@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gitgud Ready Ready Preview, Comment Jul 26, 2026 7:13am

@cameroncuster

cameroncuster commented Jul 26, 2026

Copy link
Copy Markdown
Owner Author

PR Risk Analyzer Agent🛡️

👀 Human Input Needed
A pair-review briefing is ready for you.

→ Pair Review Briefing

@cameroncuster cameroncuster left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep Code Review Agent🐛

Review completed with 0 suggestions.

@cameroncuster
cameroncuster merged commit f806064 into main Jul 26, 2026
14 checks passed
@cameroncuster
cameroncuster deleted the cameroncuster/sign-up-label branch July 26, 2026 07:15
@cameroncuster

Copy link
Copy Markdown
Owner Author

🛰️ Verifier Report

TL;DR: Drove the signed-out header in a real browser against the freshly built head and confirmed the primary CTA now reads "Sign up" on both desktop and mobile, while the GitHub-specific loading and error copy stays put.

🔍 Walkthrough

  • Desktop signed-out header now shows the "Sign up" CTA — rendered in a real browser (on main this button reads "Continue with GitHub"):
    desktop header CTA reading Sign up

  • Mobile menu shows the same "Sign up" CTA after opening the nav — captured on a Pixel 5 viewport:
    mobile menu CTA reading Sign up

  • GitHub-specific error copy is retained — after an auth failure the button is "Sign up" but the alert still reads "Couldn't open GitHub. Try again.":
    Sign up CTA with retained Couldn't open GitHub error

  • The updated auth flow specs pass on desktop and mobile — the sign-in click, the retry-after-error click, and the "Sign up" visibility assertions all green across both viewports.

    focused mocked auth run — 10 passed, 2 viewport-specific theme tests skipped
    Running 12 tests using 1 worker
    ✓ [mocked-desktop] auth-sanity.spec.ts:19 @sanity GitHub sign-in persists an admin session and logout revokes access
    ✓ [mocked-desktop] smoke.spec.ts:138 anonymous users see the GitHub action after session resolution
    ✓ [mocked-desktop] smoke.spec.ts:146 callback failure marker shows a retryable login error and retry clears it
    ✓ [mocked-mobile]  auth-sanity.spec.ts:19 @sanity GitHub sign-in persists an admin session and logout revokes access
    ✓ [mocked-mobile]  smoke.spec.ts:138 anonymous users see the GitHub action after session resolution
    ✓ [mocked-mobile]  smoke.spec.ts:146 callback failure marker shows a retryable login error and retry clears it
    10 passed (17.9s)
    

    Specs assert getByRole('button', { name: 'Sign up' }) — a stale "Continue with GitHub" label would fail them.

📋 Scope

Under test: Renames the signed-out header CTA from "Continue with GitHub" to "Sign up" on desktop and mobile (Header.svelte), keeping the Opening GitHub… loading text and Couldn't open GitHub error copy, with the two auth e2e specs updated to the new label.

Not tested:

  • The real GitHub OAuth redirect (mocked suite stubs the callback; unchanged by this copy-only PR).
  • The live smoke suite (SUPABASE_SMOKE=1, off by default, not requested).
  • Unit/lint/type-check gates — covered by CI, not re-run here.

📦 Artifacts · desktop · mobile · error state


Don't like what you see? Add a verification skill so the next run tests this kind of change.

Want another run? Comment cosmos verify on this PR.

👍 / 👎 · View session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant