feat: add an appearance setting for dark, light or system (#33) - #34
Open
robert-corlett wants to merge 1 commit into
Open
feat: add an appearance setting for dark, light or system (#33)#34robert-corlett wants to merge 1 commit into
robert-corlett wants to merge 1 commit into
Conversation
The popover followed the macOS appearance and nothing else. Settings now carries a Dark / Light / System picker, defaulting to System — the behaviour it had before. `.preferredColorScheme` on the root view is all it takes: SwiftUI applies it to the hosting window, so the popover's own material follows it too and the switch is live, with no reopen. The status item is deliberately left out of it — that is drawn into the system menu bar, which keeps the system appearance whatever the app asks for, so overriding it app-wide would leave the free-space title dark-on-dark for anyone running the two in opposite themes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Settings now carries a Dark / Light / System picker, defaulting to System. Menubar icon left untouched.
Two files changed, +39 lines: