Use new string buffer system, to enable arrays rather than linked list. - #201
Merged
Conversation
Based on the work from #21 Author: Matt Tyson Co-authored-by: Greg Sabino Mullane
Contributor
Author
|
Looking for reviews, this is a substantial bit of work. |
esabol
reviewed
Jul 2, 2026
esabol
left a comment
esabol
left a comment
Collaborator
There was a problem hiding this comment.
Just a few inline comments...
Since this does a lot of memory allocating, it might be worth doing some valgrind checks?
Contributor
Author
|
Valgrind is a good idea, but I was not able to get it working last I tried. That was many years ago, so if I get some free time I will give it another go for 2026. |
esabol
reviewed
Jul 2, 2026
esabol
left a comment
esabol
left a comment
Collaborator
There was a problem hiding this comment.
At the risk of being premature, it looks good to me.
esabol
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the work from #21
Author: Matt Tyson
Co-authored-by: Greg Sabino Mullane