fix(rockets-auth): enforce the active flag on token validation; patch RepositoryQueryException context wipe#30
Open
kauandotnet wants to merge 2 commits into
Open
Conversation
Login already enforces the active flag (LocalUserInactiveException), but RocketsJwtAuthAdapter.validateToken did not — a deactivated user could keep using outstanding access tokens until expiry. Check user.active after the subject lookup and fail with 401, mirroring the login-path semantics.
@concepta/nestjs-repository RepositoryQueryException has the same
Object.assign({}, super.context) bug as the nestjs-common/nestjs-crud
exceptions this script already patches: the derived constructor wipes
context.originalError, so consumers cannot map the underlying driver
error (e.g. postgres 23505 unique violations to 409 Conflict).
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small fixes found while running rockets-auth in production-shaped integration tests:
RocketsJwtAuthAdapternow rejects inactive users during access-token validation. Login already enforcesactive(LocalUserInactiveException), but the token path did not — a deactivated user's outstanding access tokens kept working until expiry. The adapter now checksuser.activeafter the subject lookup and fails with 401, mirroring the login-path semantics.scripts/patch-concepta-runtime-context.cjsalso patches@concepta/nestjs-repository.RepositoryQueryExceptionhas the sameObject.assign({}, super.context)bug as the nestjs-common/nestjs-crud exceptions the script already fixes: the derived constructor wipescontext.originalError, so consumers can never reach the underlying driver error (e.g. to map postgres23505unique violations to 409 Conflict).Validation
Verified downstream (NestJS 12 ESM app, postgres, HTTP integration suite): deactivating a user 401s their live access token on the very next request and reactivation restores it; with the repository patch applied, unique violations surface through
context.originalErrorand map to 409. Happy to add upstream e2e coverage for the active gate if wanted.