Improve compatibility between turtle.FormattedTuple and stdlib's turtle.Vec2D (turtle star) - #2911
Merged
Merged
Conversation
Add __abs__ method to return the absolute value of the point.
Contributor
Author
|
With the same change in Basthon turtle source I was able to draw the SVG: cc @bearney74 |
Contributor
Author
|
Slightly related: I also opened a PR to simplify this docs fragment to not use the |
Contributor
Author
|
cc @casatir -- the same issue applies to Basthon turtle, but I don't have access to post a pull request for it. |
Contributor
|
Thanks for the PR Maciej, and sorry for the late reaction, August is more dedicated to holidays and family ! |
Contributor
Author
|
Thank you! No worries. Just to mention in the meantime we've simplified code example in the turtle tutorial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Turtle module docs intro contains following script for drawing turtle star:
It draws correctly with tkinter, but
abs(pos()) < 1fails withTypeError: Bad operand type for abs(): 'FormattedTuple'for Brython (and Basthon).Fix by copying over
__abs__method implementation for stdlib.__abs__method returns the absolute value of the point.