Allow brick/math 0.18 - #129
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=========================================
Coverage 94.96% 94.96%
Complexity 452 452
=========================================
Files 43 43
Lines 1151 1151
=========================================
Hits 1093 1093
Misses 58 58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
localheinz
approved these changes
Jun 18, 2026
simPod
approved these changes
Jun 21, 2026
Member
|
Thank you, @delolmo! |
Contributor
|
@BenMorel can we get a release with this? |
Member
|
@simPod I have a few more features / BC breaks planned before I release v0.14; hopefully I'll be able to take care of this over the weekend. |
Member
|
These features are taking more time than expected, they'll be postponed to Version 0.14.0 released! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brick/math0.18.0 was recently released, but the currentcomposer.jsonconstraint (~0.15.0 || ~0.16.0 || ~0.17.0) excludes it, blocking installation of brick/money alongside brick/math 0.18.This widens the constraint to allow
~0.18.0.Compatibility
The breaking changes in brick/math 0.18 do not affect this library:
BigInteger::fromBytes()parameter rename — only affects named-argument callers; not used here.of()parsing and exponent-overflow exception changes — no affected usage.Verification (with brick/math 0.18.0 installed)
Also updated the pinned
RoundingModelink in the README from0.17.0to0.18.0.