Skip to content

Allow brick/math 0.18 - #129

Merged
BenMorel merged 1 commit into
brick:mainfrom
delolmo:support-brick-math-0.18
Jun 24, 2026
Merged

Allow brick/math 0.18#129
BenMorel merged 1 commit into
brick:mainfrom
delolmo:support-brick-math-0.18

Conversation

@delolmo

@delolmo delolmo commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

brick/math 0.18.0 was recently released, but the current composer.json constraint (~0.15.0 || ~0.16.0 || ~0.17.0) excludes it, blocking installation of brick/money alongside brick/math 0.18.

This widens the constraint to allow ~0.18.0.

Compatibility

The breaking changes in brick/math 0.18 do not affect this library:

  • BigInteger::fromBytes() parameter rename — only affects named-argument callers; not used here.
  • Stricter of() parsing and exponent-overflow exception changes — no affected usage.
  • Narrowed static-analysis return types — no impact.

Verification (with brick/math 0.18.0 installed)

  • PHPUnit: 935 tests, 1926 assertions — all passing.
  • PHPStan: no errors.

Also updated the pinned RoundingMode link in the README from 0.17.0 to 0.18.0.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.96%. Comparing base (c1dd3a6) to head (75ec5bb).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #129   +/-   ##
=========================================
  Coverage     94.96%   94.96%           
  Complexity      452      452           
=========================================
  Files            43       43           
  Lines          1151     1151           
=========================================
  Hits           1093     1093           
  Misses           58       58           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenMorel
BenMorel merged commit 34feb89 into brick:main Jun 24, 2026
9 checks passed
@BenMorel

Copy link
Copy Markdown
Member

Thank you, @delolmo!

@simPod

simPod commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

@BenMorel can we get a release with this?

@BenMorel

Copy link
Copy Markdown
Member

@simPod I have a few more features / BC breaks planned before I release v0.14; hopefully I'll be able to take care of this over the weekend.

@delolmo
delolmo deleted the support-brick-math-0.18 branch June 29, 2026 13:44
@BenMorel

Copy link
Copy Markdown
Member

These features are taking more time than expected, they'll be postponed to v0.15.

Version 0.14.0 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants