Wake JS on libuv poll errors instead of dropping the callback - #137
Open
nigrosimone wants to merge 2 commits into
Open
Wake JS on libuv poll errors instead of dropping the callback#137nigrosimone wants to merge 2 commits into
nigrosimone wants to merge 2 commits into
Conversation
nigrosimone
marked this pull request as ready for review
August 9, 2026 10:38
Owner
|
amazing job on writing tests for this, ty!! |
Author
|
The tests are success, but the ci hang to exit |
Author
|
@brianc my bad! my test don't close the sockets connections in https://github.com/brianc/node-libpq/pull/137/changes#diff-399651cdf8269b054efafa4155e009dbcb08f02e1fa57847e25d387974a8911eR34 I need to push a fix for the test afterEach(function (done) {
sockets.forEach(function (s) { s.destroy() }) // close all sockets
proxy.close(function () { done() })
})done 5c96d5b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_io_readableandon_io_writablelook only atrevents. But libuv signals a poll error withstatus < 0andrevents == 0, and before calling the callback it already runsuv__io_stopanduv__handle_stop, so the fd is out of the loop and no other event can arrive.The result is that a connection reset by the peer becomes silent while it still looks alive.
I found it with pipelined queries in pg-native, where losing a backend in the middle of a batch left
the client with a connection that never completes and never fails.