refactor(bseed) rename zigbee_switch_1_gang to EC-GL86ZPCS11 and enable dynamic load - #4586
refactor(bseed) rename zigbee_switch_1_gang to EC-GL86ZPCS11 and enable dynamic load#4586Maxik933 wants to merge 9 commits into
Conversation
bramstroker
left a comment
bramstroker
left a comment
There was a problem hiding this comment.
Thanks for the PR. Two remarks.
And could you also have a look into: https://library.powercalc.nl/profiles/bseed/zigbee-switch-1-gang-no-neutral.
That's a similar profile and we would like to stay consistent regarding model id's and naming for similar vendor.
| "model_id": "EC-GL86ZPCS11", | ||
| "device_type": "smart_switch", | ||
| "calculation_strategy": "fixed", | ||
| "measure_device": "Shelly Plug S", |
There was a problem hiding this comment.
Just to clarify: zigbee-switch-1-gang-no-neutral was actually the old generic folder name for this exact hardware that I created previously.
My goal with this PR is to rename that legacy folder to the official model number EC-GL86ZPCS11 (instead of keeping a duplicate) and update it to support dynamic load configuration.
Let me know if you prefer keeping the old folder name as an alias or if renaming/refactoring it directly works for you
There was a problem hiding this comment.
I see, sorry for confustion.
Yes I definitely like to have the official model number as directory name, that's preferred and consistent with most other profiles in powercalc DB.
So I like this change. My suggestion to add legacy_ids can be ignored as there are no users yet using the profile actively, so we can avoid poluting the DB with that.
But we must also apply the official model number (directory rename) to the other non neutral profile in library so things get consistent.
Could you also take care of that one in same PR, thanks.
There was a problem hiding this comment.
@bramstroker
This PR renames bseed/zigbee_switch_1_gang → bseed/EC-GL86ZPCS11. That’s the Badezimmer switch with the official Bseed model number.
I left bseed/zigbee_switch_1_gang_no_neutral untouched on purpose. That profile matches my Flur switch, which Home Assistant discovers via Zigbee2MQTT as Smart light switch - 1 gang (TS0011) / manufacturer Tuya. As you explained in #4444, TS0011 is a generic identifier shared across many OEMs, so it cannot be renamed to a single Bseed model without affecting unrelated devices.
Let me know if you’d like me to handle that one differently, otherwise I’d prefer to keep this PR scoped to the EC-GL86ZPCS11 rename only.
There was a problem hiding this comment.
Sorry @Maxik933. I'm a tiny bit confused, so I cannot give the right solution yet.
Important question before continuing.
Are both the exact same bseed model or not? I assumed the only difference was that one was connected with neutral and the other was connected without neutral.
If the Flur switch is a different one, please also share the bseed link of that model.
There was a problem hiding this comment.
https://www.amazon.de/dp/B093WP7BGW?th=1 is a smart light switch – 1-gang (TS0011)
by Tuya
https://www.amazon.de/dp/B0FK57V129?th=1 is a 1-gang switch with scene function and backlight (EC-GL86ZPCS11)
by BSEED (formerly Bseed) zigbee_switch_1_gang
I made the mistake early on of not setting it up correctly, and now I want to correct that mistake.
There was a problem hiding this comment.
I mean we want to be consistent in the library, and not have some self invented model ids as the directory name.
We have corrected it now in this PR, which is nice.
However the other profile can also be corrected so at least the info in the library is correct.
I have done some research and it appears to be this one: https://www.bseed.com/products/bseed-zigbee-switch-wall-smart-light-switch-1gang-2-way-single-live-line
The correct model id for that is SL-GL86ZTS11B.
Than we nicely have both the devices use there actual model number in the library.
That the latter is listed as Tuya TS001 that's because it's missing in Zigbee2Mqtt database probably. I'm not using that myself so don't know all the ins and outs, but you can report/add it there.
I think the instructions are here to add whitelabel: https://www.zigbee2mqtt.io/advanced/support-new-devices/02_support_new_tuya_devices.html?utm_source=chatgpt.com#fixing-tuya-device-detection
| "model_id": "EC-GL86ZPCS11", | ||
| "device_type": "smart_switch", | ||
| "calculation_strategy": "fixed", | ||
| "measure_device": "Shelly Plug S", |
There was a problem hiding this comment.
Just to clarify: zigbee-switch-1-gang-no-neutral was actually the old generic folder name for this exact hardware that I created previously.
My goal with this PR is to rename that legacy folder to the official model number EC-GL86ZPCS11 (instead of keeping a duplicate) and update it to support dynamic load configuration.
Let me know if you prefer keeping the old folder name as an alias or if renaming/refactoring it directly works for you
|
Wait a sec, is this exactly the same device but only neatral vs no_neutral? |
Maxik933
changed the title
Co-authored-by: Bram Gerritsen <bgerritsen@gmail.com>
Co-authored-by: Bram Gerritsen <bgerritsen@gmail.com>
|
@Maxik933 Seems you closed by accident? |
|
@bramstroker |
2 participants
Description
Refactored the BSEED 1-gang switch profile to match current Powercalc directory conventions and enable dynamic load support.
Summary of Changes:
zigbee_switch_1_gangfolder and migrated the files to the properbseed/EC-GL86ZPCS11directory path.model_id: "EC-GL86ZPCS11"inmodel.jsonto enable automatic Zigbee device discovery.fixed_configwithstandby_power_on: 0.89to track internal operating consumption while prompting users to enter their connected light load upon setup.nameandmeasure_descriptionto accurately reflect the BSEED 1-gang scene & backlight switch hardware.Checklist: