Add security and CI remediation plan - #32
Open
PeterRounce wants to merge 1 commit into
Open
Conversation
Records the six outstanding items found while auditing this repo for CVE-2026-71851 ("Ill Bloom"), which this repo is NOT exposed to. Documents-only change. No code, config or workflow is touched. Captures for each item the problem, the options with trade-offs, and a recommendation - so the decisions stay open rather than pre-made. Two sections exist specifically to prevent false confidence: "Expectations" notes that fixing CI makes it able to run but does not imply the suite passes, and "Out of scope" states plainly that this is one audit thread rather than a security review of the repo. Also records three design decisions for the wallet-at-rest KDF work that are not recoverable from the code itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9eFm5MqyhJZvzN2tNopAU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
docs/plans/2026-08-12-security-and-ci-remediation.md. Documents only — no code, config, or workflow is touched.Why
Records the six outstanding items found while auditing this repo for CVE-2026-71851 ("Ill Bloom"), so they don't live only in a chat log. Kept separate from #31 and #30 so those stay easy to approve on their mechanical merits.
npm installfails buildingrn-ldkgit depgetRealm()unsalted SHA-256 + hardcoded default keyRecommended order is 1 → 2 → 3 → 4 (with 5 folded in), because nothing can be test-gated until CI runs.
Headline for anyone skimming
This repo is not, and never was, exposed to Ill Bloom. CVE-2026-71851 affects
crypto-js < 4.0.0; this repo has always been on 4.x.class/Ntag424.jsdoes referenceCryptoJS.lib.WordArray— the symbol named in that advisory — but uses.init()to build word arrays for an XOR, not.random(). No seed or key entropy here comes from crypto-js.The genuinely high-severity item is 4, which is unrelated to any advisory:
blue_modules/encryption.jscallsAES.encrypt(data, passwordString), and passing a string password routes through OpenSSLEvpKDF— MD5, one iteration, 8-byte salt. Password guessing against a stolen storage blob costs roughly one MD5 per attempt. No crypto-js version changes this.How to read it
Each open item lists options with trade-offs and a recommendation, rather than a pre-made decision — the choices are still yours. Item 4 also records three design decisions already taken that aren't recoverable from the code (fork-only/mergeable, drop decoy buckets, block migration for multi-bucket users).
Two sections are there specifically to stop this doc creating false confidence:
Note on CI
Checks on this PR will fail at
Install node_modules— that's item 2, present on master and unrelated to a markdown file. It'll keep happening to every PR until item 2 is fixed.🤖 Generated with Claude Code
https://claude.ai/code/session_01L9eFm5MqyhJZvzN2tNopAU