test(comp): review proposal 595 calldata - #104
Open
blockfulintern wants to merge 3 commits into
Open
Conversation
Read the proposal with proposalDetails (the Bravo address now hosts an OZ-style Governor) and compare the derived calldata against it, so the committed fixture is verified instead of trusted. Decode the inner cross-chain payloads out of the live calldata rather than re-decoding the encoder's own output, assert a meaningful proposal state, check the GHO approval against a live CCIP fee quote, and execute the five L1 calls as the Timelock on a mainnet fork. Also drop the unused interfaces/constants and point the Compound registry entry away from a single proposal's test file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proposalDetails, not the committed fixture)Verdict
NEEDS_REVIEW — L1 calldata matches the chain and executes cleanly; downstream L2 relay execution is not simulated.
Verification
Result: 5 passed, 0 failed.