fix(quickstart): use ytt comment syntax in deps compose - #738
Merged
Conversation
quickstart/bin/re-render.sh feeds dev/docker-compose.deps.yml to ytt, which rejects plain "#" comments. #657 added three, so re-render.sh aborts and the Concourse prep-quickstart task fails before check-quickstart ever runs. Quickstart image bumps stopped Jul 28. Switch to "#!" — the syntax already used inline a few lines above. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a quickstart pipeline breakage introduced by #657.
Problem
quickstart/bin/re-render.shfeedsdev/docker-compose.deps.ymlto ytt, which requires every comment to be#@(annotation/code) or#!(comment). #657 added three plain#comment lines above the kratoscommand:, so the render aborts:Before #657 the file had exactly one
#line — the#@data/valuesannotation on line 1.re-render.shruns underset -e, soci/core/tasks/prep-quickstart.shfails and the Concoursequickstartjob dies atprep-quickstart, beforecheck-quickstartever runs.Corroboration:
quickstart/docker-compose.ymlwas bumped daily (Jul 26, 27, 28) and has had no bump since #657 merged on Jul 29.Fix
Switch the three lines to
#!— the syntax already used inline a few lines above (- "4433:4433" #! public). ytt strips#!comments from the output, so the rendered compose is unaffected.Not the cause: the lnurl sqlite
:memory:switchWorth recording, since it was the first suspect.
lnurl-serverin quickstart is hardcoded inquickstart/docker-compose.tmpl.yml, not sourced fromdev/docker-compose.deps.yml— the deps file only supplies data values for a subset of services. SoLNURL_DB_URL=:memory:never reaches quickstart; the rendered compose keepssqlite:///data/lnurl.db?mode=rwcand the/datamount. (The image also boots fine standalone with:memory:.)Verification
With this fix
yttrenders cleanly, and the output differs from the committedquickstart/docker-compose.ymlby exactly one line — kratos losing--watch-courier, which is #657's intent.Booted that rendered compose locally (29 services) and ran
./bin/quickstart.sh, i.e. whatcheck-quickstart.shdoes: onchain + lightning init, channel funding,globals.network→regtest, Alice login and account setup → token issued. Passes.quickstart/docker-compose.ymlis deliberately left untouched here —prep-quickstartregenerates and commits it (along with the vendir ref and image digest bumps) on the next pipeline run.Follow-ups (not in this PR)
re-render.shbreakage is caught on PR rather than only in Concourse.lnurl-serverblock trackdev/instead of being hardcoded in the template, so the two don't drift.🤖 Generated with Claude Code