feat(wind-down): price cohort USD->BTC self-conversions at mid rate - #733
Open
littledino2112 wants to merge 1 commit into
Open
feat(wind-down): price cohort USD->BTC self-conversions at mid rate#733littledino2112 wants to merge 1 commit into
littledino2112 wants to merge 1 commit into
Conversation
Cohort accounts converting USD to their own BTC wallet get the exchange mid rate instead of the dealer immediate-sell spread, behind windDown.convertUsdToBtcAtMidPrice (default false). Pricing-slot swap at the intraledger call site only; builder, ledger, limits untouched.
esaugomez31
reviewed
Jul 29, 2026
Comment on lines
21
to
+22
| import { checkReceiveAllowed } from "@/app/wind-down/check-receive-allowed" | ||
| import { isAccountInWindDownCohort } from "@/app/wind-down/is-account-in-wind-down-cohort" |
Collaborator
There was a problem hiding this comment.
not a blocker but both can use the barrel
Suggested change
| import { checkReceiveAllowed } from "@/app/wind-down/check-receive-allowed" | |
| import { isAccountInWindDownCohort } from "@/app/wind-down/is-account-in-wind-down-cohort" | |
| import { checkReceiveAllowed, isAccountInWindDownCohort } from "@/app/wind-down" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the custodial wind-down, cohort accounts convert their USD balance to BTC before migrating out. There is no swap-fee line item in core to waive — the cost of a conversion is the dealer spread baked into stablesats' immediate-sell quote — so behind
windDown.convertUsdToBtcAtMidPrice, a self-trade from a cohort account's USD wallet to its own BTC wallet fills the payment builder'shedgeSellUsdslot with the mid-price fns instead of the dealer quote fns. The builder, ledger entries, and trade limits are untouched.