refactor: use slices.Equal to simplify code - #2211
Merged
Merged
Conversation
CascadingRadium
previously approved these changes
Jul 28, 2025
CascadingRadium
requested review from
CascadingRadium,
Likith101,
Thejas-bhat and
abhinavdangeti
July 28, 2025 07:52
abhinavdangeti
requested changes
Jul 28, 2025
abhinavdangeti
left a comment
abhinavdangeti
left a comment
Member
There was a problem hiding this comment.
Thanks for this contribution @houpo-bob .
However it seems this change is incomplete. There're references to ArrayPositions' Equals method.
Signed-off-by: houpo-bob <houpocun@outlook.com>
Contributor
Author
|
Modified. Please review it again. Thanks😄 |
CascadingRadium
approved these changes
Jul 30, 2025
abhinavdangeti
approved these changes
Jul 30, 2025
CascadingRadium
pushed a commit
that referenced
this pull request
Aug 21, 2025
In the Go 1.21 standard library, a new function has been introduced that enhances code conciseness and readability. It can be find [here](https://pkg.go.dev/slices@go1.21.1#Equal). Signed-off-by: houpo-bob <houpocun@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Go 1.21 standard library, a new function has been introduced that enhances code conciseness and readability. It can be find here.