MB-67212: Supporting search_after/search_before for deep pagination over non textual content - #2208
Merged
Merged
Conversation
…in TopNCollector - Introduced new test cases for searching after numeric, datetime, and geo fields. - Implemented encoding for pagination on these fields to enhance search capabilities. - Updated the createSearchAfterDocument function to support encoded sort values. - Ensured proper handling of search results in the new test cases. This enhances the search functionality by allowing users to paginate through results based on specific criteria.
capemox
requested review from
CascadingRadium,
Likith101,
Thejas-bhat,
abhinavdangeti and
metonymic-smokey
July 18, 2025 05:36
…nd geo fields - Added a new function `validatePagination` to check the validity of `SearchAfter` and `SearchBefore` values based on the sort order. - Introduced comprehensive test cases to validate pagination behavior for various field types. - Updated the `SearchRequest.Validate` method to incorporate pagination validation. - Adjusted the handling of encoded sort values in the `TopNCollector` for improved search functionality.
CascadingRadium
approved these changes
Jul 21, 2025
abhinavdangeti
left a comment
abhinavdangeti
left a comment
Member
There was a problem hiding this comment.
@capemox would we not need to extend support for search_before as well or do both paths have overlap?
In a separate follow up PR, would you add a docs/pagination.md following similar syntax to the others in docs/ showcasing how users can use the traditional pagination and how they can use search_after/search_before for better performance during deep pagination.
| } | ||
|
|
||
| // Creates a dummy document to compare with for pagination. | ||
| func createSearchAfterDocument(sort search.SortOrder, after []string) *search.DocumentMatch { |
Member
There was a problem hiding this comment.
I forget this, but are there no such utilities for searchBefore?
Member
Author
There was a problem hiding this comment.
Internally, SearchBefore is converted to a SearchAfter problem by reversing the sort order, so we don't need to handle both cases separately
Lines 584 to 589 in 487fa5f
abhinavdangeti
approved these changes
Jul 21, 2025
abhinavdangeti
left a comment
abhinavdangeti
left a comment
Member
There was a problem hiding this comment.
Great work @capemox ! Feel free to merge away.
CascadingRadium
pushed a commit
that referenced
this pull request
Aug 21, 2025
…ver non textual content (#2208) Add search after functionality for numeric, datetime, and geo fields in TopNCollector - Introduced new test cases for searching after numeric, datetime, and geo fields. - Implemented encoding for pagination on these fields to enhance search capabilities. - Updated the createSearchAfterDocument function to support encoded sort values. - Ensured proper handling of search results in the new test cases. This enhances the search functionality by allowing users to paginate through results based on specific criteria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add search after functionality for numeric, datetime, and geo fields in TopNCollector
This enhances the search functionality by allowing users to paginate through results based on specific criteria.