Redesign dataset provenance modal#389
Open
SanjeevLakhwani wants to merge 9 commits into
Open
Conversation
Extract ModalHeader, SideNav, SummarySection, SpatialCoverageSection, ParticipantCriteriaSection, IdentifiersSection, and cards into separate files. Main modal drops from 1113 to 357 lines. longDescExpanded state is now local to SummarySection. Removes unused sectionRefs. Adds styles.css for pm- modal styles.
Remove person avatars, fullscreen toggle, and logo section from the provenance modal.
…ader privacy pill Publications now render as collapsible dense rows instead of full cards, since datasets can carry 20+ entries. Person names no longer double up honorific prefixes already present in the source name. Header meta strip no longer repeats privacy (still shown in Access & License section).
…ards.tsx DatasetProvenanceModal and its section/nav/header helpers now live under Provenance/Modal/ instead of flat alongside unrelated page-level and catalogue components. cards.tsx (382 lines, 8 unrelated components) is split into one file per component under Modal/cards/, with shared type helpers extracted to Modal/cards/helpers.ts.
SanjeevLakhwani
marked this pull request as draft
July 6, 2026 13:18
Reformat via prettier --fix. Replace the dataset-change reset effect with the render-time state adjustment pattern (avoids setState-in-effect cascading renders), rewrite a ternary-as-statement into if/else, and drop the unused idx prop on FundingCard.
SanjeevLakhwani
marked this pull request as ready for review
July 6, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.