Bound the pooled TLS upgrade handshake with connect_timeout - #922
Merged
Conversation
The pooled HTTPS upgrade called ssl:connect/2, which has no handshake deadline. A server that accepts TCP then stalls the TLS handshake pinned the connection process and its pool slot indefinitely, past connect_timeout and recv_timeout. The proxy upgrade paths were already hardened for this; the pooled direct path was not. Pass the connection's connect_timeout to ssl:connect/3 so a stalled handshake fails instead of hanging.
benoitc
force-pushed
the
fix/pooled-tls-upgrade-timeout
branch
from
August 9, 2026 09:09
0359367 to
3d048b1
Compare
Merged
benoitc
added a commit
that referenced
this pull request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pooled HTTPS upgrade in
hackney_conn:upgrade_to_sslcalledssl:connect/2, which has no handshake deadline. A server that accepts TCP then stalls the TLS handshake pins the connection process and its pool slot indefinitely, pastconnect_timeout. The proxy upgrade paths were already hardened; the pooled direct path was not. Pass the connection'sconnect_timeouttossl:connect/3so a stalled handshake fails instead of hanging.