Added unit tests for private.js#1120
Open
haxwell wants to merge 19 commits into
Open
Conversation
Author
|
This is failing because the 'sinon' library is not present. I added it so as to test the isAccount() method. It is a devDependency listed in the package.json. I'm surprised that that is not being picked up. |
… because it didn't have sinon, a package used for mocks, stubs, etc in testing, even though it is defined in package.json.
…d (or not, as the case may be). Also implemented remaining coverage tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.