fix: do not emit time spacer tokens twice in unfused mode#7
Closed
brettbj wants to merge 1 commit into
Closed
Conversation
get_pretokenized wraps the event token list in concat_list(t_spacer, <inner>); the unfused branch's inner list also began with t_spacer, so every non-null spacer appeared twice in the timeline, e.g. [TIME//1h-2h, TIME//1h-2h, LAB//x, Q3]. Drop t_spacer from the inner list; the outer concat_list already provides it for both modes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes duplicate emission of time spacer tokens in unfused tokenization mode by ensuring t_spacer is only added once to the to_tokenize list (via the outer pl.concat_list(...)), matching the already-correct fused behavior.
Changes:
- Remove
t_spacerfrom the unfused branch’s innerpl.concat_list(...)to prevent duplicate spacer tokens in the output timeline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_pretokenized wraps the event token list in
concat_list(t_spacer, ); the unfused branch's inner list also began with t_spacer, so every non-null spacer appeared twice in the timeline, e.g. [TIME//1h-2h, TIME//1h-2h, LAB//x, Q3]. Drop t_spacer from the inner list; the outer concat_list already provides it for both modes.