Skip to content

Add virtual-scroll useKeyboard option support - #106

Open
weotch wants to merge 3 commits into
baptistebriel:masterfrom
weotch:add-use-keyboard
Open

Add virtual-scroll useKeyboard option support #106
weotch wants to merge 3 commits into
baptistebriel:masterfrom
weotch:add-use-keyboard

Conversation

@weotch

@weotch weotch commented Jun 10, 2019

Copy link
Copy Markdown

This adds support for the useKeyboard option: https://github.com/ayamflow/virtual-scroll/blob/master/src/index.js#L37.

Also, it fixes issues where a user might set a boolean option to false explicitly but, instead, the default value would be use. Like right now, if preventTouch is false like:

new SmoothCustom({
  vs: { preventTouch: false }
})

... It will get re-set to true via:

this.options.vs.preventTouch || true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant