Skip to content

ci: schedule long-running OTel conformance tests - #665

Merged
zhongkechen merged 2 commits into
mainfrom
otel-long-running-schedule
Aug 21, 2026
Merged

ci: schedule long-running OTel conformance tests#665
zhongkechen merged 2 commits into
mainfrom
otel-long-running-schedule

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore the daily 07:00 UTC trigger from the former shared Python OpenTelemetry workflow
  • let scheduled events drive the reusable orchestrator's automatic long-running check/launch cycle
  • cover the schedule in the existing workflow contract test

Related issue: aws/aws-durable-execution-conformance-tests#90

Related PRs:

Testing

  • executed test_opentelemetry_conformance_caller_uses_current_workflow_contract directly
  • parsed .github/workflows/opentelemetry-conformance-tests.yml successfully with Ruby YAML
  • git diff --check

@github-actions

This comment has been minimized.

Comment thread .github/workflows/opentelemetry-conformance-tests.yml
@github-actions

This comment has been minimized.

@ayushiahjolia
ayushiahjolia force-pushed the otel-long-running-schedule branch from fc0bd21 to a48092e Compare August 21, 2026 17:06
@ayushiahjolia
ayushiahjolia temporarily deployed to ai-pr-review-runtime August 21, 2026 17:06 — with GitHub Actions Inactive
@ayushiahjolia
ayushiahjolia temporarily deployed to ai-pr-review-runtime August 21, 2026 17:06 — with GitHub Actions Inactive
@zhongkechen
zhongkechen merged commit 0e3635b into main Aug 21, 2026
26 of 27 checks passed
@zhongkechen
zhongkechen deleted the otel-long-running-schedule branch August 21, 2026 17:07
- "packages/aws-durable-execution-sdk-python-conformance-tests-otel/**"
- ".github/workflows/opentelemetry-conformance-tests.yml"
schedule:
- cron: "0 7 * * *"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex AI review

[P2] Move the schedule off minute zero

GitHub may delay or drop scheduled runs during the high-load start-of-hour window. A dropped run here skips the automatic check/launch cycle for a full day. Use a non-zero minute, as the repository already does for other schedules, and update the test assertion accordingly.

@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

Found one reliability issue in the new scheduled trigger. The external reusable workflow implementation is outside the supplied diff.

Reviewed commit a48092e26f1dadc1328cc734e4463652bfea0de4. Workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Claude AI review

CI-only change to .github/workflows/opentelemetry-conformance-tests.yml: adds a daily schedule trigger (cron: "0 7 * * *"), bumps the reusable orchestrator pin from 8de1bbfd… to 91740c98…, and extends the contract test to cover the schedule and match the new revision.

No actionable findings in the changed lines.

  • The orchestrator SHA is consistent between the workflow (opentelemetry-conformance-tests.yml:59) and the test constant (test_opentelemetry_conformance_workflow.py:7), so the contract test stays green.
  • The new assertion ' schedule:\n - cron: "0 7 * * *"' matches the added YAML indentation exactly, so it passes rather than always failing.
  • schedule correctly runs on the default branch and bypasses the paths filter as intended; on a scheduled event the caller inputs resolve via their fallbacks (sdk_refgithub.sha, conformance_test_ref'main').

Residual risk (unverifiable here, not a defect in this diff): the PR aims for scheduled events to drive the orchestrator's long-running check/launch cycle, but the caller still passes phase: ${{ inputs.phase || 'short' }}, which resolves to short on a scheduled run. Whether the daily run actually launches/checks the long-running suite depends on the pinned orchestrator (91740c98…) branching on github.event_name == 'schedule' internally. That orchestrator is in aws/aws-durable-execution-conformance-tests and outside this diff — worth confirming it keys off the event name rather than phase, otherwise the scheduled run would only run short tests.

Reviewed commit a48092e26f1dadc1328cc734e4463652bfea0de4. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants