fix: move github.event.pull_request.base.ref into env var in bootstrap-template-protection workflow#1744
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
sanjanaravikumar-az
approved these changes
Jul 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
+ Coverage 89.59% 89.67% +0.07%
==========================================
Files 78 78
Lines 11796 11796
Branches 1657 1662 +5
==========================================
+ Hits 10569 10578 +9
+ Misses 1198 1189 -9
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
The
upgradeworkflow fails when it updatescdklabs-projen-project-typesto a newer version. A check added in cdklabs/cdklabs-projen-project-types#957 refuses to let any workflow put${{ github.event.* }}values straight into a shell command, because that data comes from the pull request and could be used to sneak in unwanted commands.The "Checkout base branch" step in the
bootstrap-template-protectionworkflow used the branch name directly in its command:run: git fetch origin ${{ github.event.pull_request.base.ref }}Every other step in the same file already passes this value in through an environment variable.
This PR passes the branch name in as an environment variable and uses it in the command, the same way the neighboring steps do:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license