Skip signature verification in PutApprovals when same PK#463
Open
yacovm wants to merge 2 commits into
Open
Conversation
- When failing verifying a block, e.replicationState.ResendFinalizationRequest is invoked and it's not thread safe. - computeNewApprovals of MSM referenced the approval store but without memory coherency. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
PutApprovals copies approvals from the current store to a given store. It snapshots the approvals and then calls HandleApproval on each approval, but it also performs a signature verification which is redundant, because the signature was already checked the first time it was inserted into the current approval store. This commit simply refactors the code to enable PutApprovals to skip the signature check if it has the same PK. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PutApprovals copies approvals from the current store to a given store.
It snapshots the approvals and then calls HandleApproval on each approval,
but it also performs a signature verification which is redundant, because the signature
was already checked the first time it was inserted into the current approval store.
This commit simply refactors the code to enable PutApprovals to skip the signature check if it has the same PK.