Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wal/wal.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func (w *WriteAheadLog) Append(b []byte) error {

func (w *WriteAheadLog) Delete() error {
if w.file == nil {
return os.Remove(w.file.Name())
return os.Remove(w.fileName)
}

if err := w.file.Close(); err != nil {
Expand Down
35 changes: 35 additions & 0 deletions wal/wal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,41 @@ func TestDelete(t *testing.T) {
require.ErrorIs(err, os.ErrNotExist)
}

func TestDeleteWhenFileNil(t *testing.T) {
t.Run("never opened", func(t *testing.T) {
require := require.New(t)

fileName := filepath.Join(t.TempDir(), "simplex.wal")
require.NoError(os.WriteFile(fileName, nil, WalPermissions))

wal := New(fileName)

require.NotPanics(func() {
require.NoError(wal.Delete())
})

_, err := os.Stat(fileName)
require.ErrorIs(err, os.ErrNotExist)
})

t.Run("closed before delete", func(t *testing.T) {
require := require.New(t)

fileName := filepath.Join(t.TempDir(), "simplex.wal")
wal := New(fileName)

require.NoError(wal.Append([]byte{3, 4, 5}))
require.NoError(wal.Close()) // w.file is now nil

require.NotPanics(func() {
require.NoError(wal.Delete())
})

_, err := os.Stat(fileName)
require.ErrorIs(err, os.ErrNotExist)
})
}

func TestReadWriteAfterTruncate(t *testing.T) {
require := require.New(t)

Expand Down
Loading