Skip to content

Ignore unknown kty in KeySet.import_key_set (RFC 7517 §5) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lepture merged 2 commits into from
Jul 25, 2026
Merged

Ignore unknown kty in KeySet.import_key_set (RFC 7517 §5) #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e21fc7
Ignore unknown kty in KeySet.import_key_set (RFC 7517 Section 5)
RalphBragg Jul 24, 2026
ea19ea6
Use try/except InvalidKeyTypeError per maintainer feedback
RalphBragg Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/joserfc/_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,13 @@ def import_key_set(cls, value: KeySetSerialization, parameters: KeyParameters |
keys: list[Key] = []

for data in value["keys"]:
keys.append(cls.registry_cls.import_key(data, parameters=parameters))
# RFC 7517, Section 5: ignore a key whose "kty" is not understood
# rather than failing the whole set (for example a post-quantum key
# published alongside classical ones).
try:
keys.append(cls.registry_cls.import_key(data, parameters=parameters))
except InvalidKeyTypeError:
continue

if not keys:
raise MissingKeyError("No keys to import")
Expand Down
10 changes: 10 additions & 0 deletions tests/jwk/test_jwk_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ class TestKeySet(TestCase):
def test_import_empty_key_set(self):
self.assertRaises(MissingKeyError, KeySet.import_key_set, {"keys": []})

def test_import_key_set_ignores_unknown_kty(self):
# RFC 7517 Section 5: a key with an unrecognised "kty" is ignored, not fatal.
jwks = {"keys": [
{"kty": "unknown", "alg": "X", "kid": "unknown"},
{"kty": "oct", "k": "MDEyMzQ1Njc4OWFiY2RlZg", "kid": "classical"},
]}
key_set = KeySet.import_key_set(jwks)
self.assertEqual(len(key_set.keys), 1)
self.assertEqual(key_set.keys[0].kid, "classical")

def test_generate_and_import_key_set(self):
jwks1 = KeySet.generate_key_set("RSA", 2048)
self.assertEqual(len(jwks1.keys), 4)
Expand Down
Loading