fix: respect custom filename during PDF generation - #846
Open
Jannik-cmyk wants to merge 1 commit into
Open
Conversation
Jannik-cmyk
requested review from
asyncapi-bot-eve,
derberg and
magicmatatjahu
as code owners
July 30, 2026 18:42
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
outFilenameas the source HTML file during PDF generationRoot cause
The HTML template writes the generated documentation to
params.outFilename || 'index.html', but the PDF hook always readindex.htmland wroteindex.pdf. PDF generation therefore failed orgenerated the wrong output whenever
outFilenamewas customized.Validation
node --check hooks/99_generatePdf.jsnode --check test/hooks/99_generatePdf.test.jsbrowser cleanup and failure paths
git diff --checknpm run lintThe repository Jest and generator suites could not be executed locally because
the required dependencies and CLI were unavailable in the execution
environment. They will be validated by the repository CI.
Fixes #826