fix(ci): pass --all to mix igniter.upgrade so the job stops failing - #2841
Merged
Conversation
The job invoked `mix igniter.upgrade --git-ci --yes` with neither package names nor `--all`, so it exited 1 with "Must specify at least one package to upgrade or use --all to upgrade all packages." before doing any work. Every dependabot PR across the ecosystem has failed this check since the step was converted to the `mix-task` action and lost its argument. Under `--git-ci` the set of packages to upgrade comes entirely from diffing `HEAD~1:mix.lock` against the loaded deps, and the dependency fetch is skipped, so `--all` only satisfies the argument check — it does not widen what gets upgraded or touch `mix.lock`.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared
mix igniter.upgradejob fails on every dependabot PR across theecosystem:
The job passes neither package names nor
--all, somix igniter.upgraderejects the invocation before doing any work. Confirmed identical in
ash,ash_postgres,ash_phoenix,ash_graphqlandash_ai— anything using thisworkflow.
It broke in ff418c2 ("ci: setup action properly for igniter.upgrade"), which
converted the step from a
run:to thestaple-actions/mix-taskaction anddropped the argument along the way:
Nothing surfaced it because the step only runs for dependabot PRs. On tag pushes
it's skipped, and
build-release/hex_publishgate on!failure(), whichtreats skipped as fine — so releases were never blocked and the failure just sat
on dependabot PRs as a red X.
--allis the right argument rather than restoringdependency-names: under--git-cithe upgrade set is derived entirely from diffingHEAD~1:mix.lockagainst the loaded deps, and the dependency fetch is skipped, so
--allonlysatisfies the argument check. It doesn't widen what gets upgraded or touch
mix.lock.Verified end-to-end in a scratch project with a simulated dependabot lock bump:
--git-ci --yesexits 1 with the error above,--git-ci --yes --allexits 0 andreports
jason 1.4.4 => 1.4.5withmix.lockunmodified.Igniter shouldn't have demanded the argument in the first place, since it never
reads it on the
--git-cipath — ash-project/igniter#397 fixes that end. Thischange is worth landing regardless: it's a one-liner, it works against released
igniter, and it unblocks dependabot PRs now instead of after an igniter release.