Fix error in tools:unlink-creators - #2416
Open
danloveg wants to merge 1 commit into
Open
Conversation
The tools:unlink-creator command was failing because app_i18n_languages was not set. This is a setting that comes from the Qubit settings, and must explicitly be loaded. The arBaseTask's execute() function loads the settings, which fixes the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2414
The
tools:unlink-creatorscommand was failing because theapp_i18n_languagessetting was not set. This is a setting that comes from the database, and must explicitly be loaded when a CLI task runs. Switching the inherited class fromsfBaseTasktoarBaseTaskand calling that class'sexecute()function loads the settings and fixes the bug.