Velocity base rate limiting#948
Draft
bitcoin-coder-bob wants to merge 2 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
Ports the velocity rate limiter onto master's settings architecture. Rate-limit config (enabled/max velocity/max cooldown) lives in domain.Settings and is disabled by default. Markers gain a created_at column so the limiter can measure chain growth, and offchain tx submission rejects inputs whose VTXO chain grows faster than the configured velocity.
bitcoin-coder-bob
force-pushed
the
bob/velocity-base-rate-limiting
branch
from
57de9e0 to
0a80108
Compare
- reject invalid rate-limit values (velocity <= 0, negative cooldown) in Settings.Validate - expose rate-limit settings through the admin UpdateSettings API - cover legacy created_at 0, the timeDelta guard, and cooldown metadata in unit tests - add an e2e smoke test and document the ARKD_RATE_LIMIT_* settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #940
Work paused on this until #908 is merged in
forked off the branch
bob/dag-1which is in PR: #908 as that branch has requisite changes needed to implement the features of this branch.