Support all in batch coordinate ranges - #156
Open
arjunrajlab wants to merge 3 commits into
Open
Conversation
arjunrajlab
marked this pull request as ready for review
July 19, 2026 11:52
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f55e54fe1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allin Batch XY, Batch Z, and Batch Time fieldsallfrom datasetIndexXY,IndexZ, andIndexTmetadata, with single-position fallbacks for missing dimensionsallvalue in Crop range fields and the legacy Cellori loopWhy
Batch fields previously accepted only numeric ranges such as
1-3, 5-8. The range parser had no dataset-dimension context, so the literalallcould not be expanded safely and instead failed numeric parsing. This change centralizes dataset-aware expansion while preserving existing numeric and current-tile behavior.User impact
Users can now type
all(case-insensitive, with surrounding whitespace allowed) to process every available XY position, Z slice, or time point. Datasets without a correspondingIndexRangedimension correctly resolve to coordinate0.Validation
annotation_utilities: 22 tests passedworker_client: 14 tests passedgit diff --checkpassed