SPI: Prevent SPI.end() from hanging before initialization - #551
Open
JudjinGM wants to merge 1 commit into
Open
Conversation
|
|
JudjinGM
force-pushed
the
fix/spi-end-before-begin
branch
from
July 30, 2026 09:17
7bbe9a0 to
5651f2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
SPI.end()beforeSPI.begin()causes the board to become unresponsive.ArduinoSPI::end()calls the_closefunction pointer even when SPI has not been initialized. The_closepointer is assigned duringSPI.begin(), so it is not valid before initialization.This change makes
ArduinoSPI::end()return early when_is_initializedisfalse.Fixes: #552