fix: avoid repeated SDRAM allocator setup - #1117
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
Track the SDRAM malloc block after it is registered so begin() does not add the same global allocator region again. Repeating the same start address is treated as an idempotent call, while changing it after allocator setup fails. Fixes arduino#1105 Generated-by: OpenAI Codex Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDRAM.begin()from adding another global allocator block after one was already registeredValidation
git diff --checkSDRAM.begin()flow and theea_mallocfreelist setup to keep the guard at the singlemalloc_addblock()call siterg -n "malloc_addblock|malloc_start_address|int SDRAMClass::begin" libraries/Portenta_SDRAM/src libraries/ea_malloc -SI did not run a full Arduino board build locally because the required board/toolchain setup is not provisioned here.
Fixes #1105
CI notes
license/clacheck is pending.