Bug fix: Removed string "px !important;" from $font_size which should have only number seeing its usage - #434
Open
hikarine3 wants to merge 1 commit into
Open
Bug fix: Removed string "px !important;" from $font_size which should have only number seeing its usage#434hikarine3 wants to merge 1 commit into
hikarine3 wants to merge 1 commit into
Conversation
removed ". 'px !important;'" because its value is used as number and it is yeilding warning like
Notice: A non well formed numeric value encountered in /var/www/web/app/plugins/crayon-syntax-highlighter/crayon_formatter.class.php on line 118
And this string is added in different lines, so removing should be O.K.
hikarine3
changed the title
hikarine3
changed the title
|
I was having the same issue and your fix works. Hopefully, this will get merged into the code. |
|
I think it would be better to change on lines 118 & 119 |
|
This PR isn't a valid fix. As @xavier-bs noted, the fix should be made at lines 118 & 119. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed ". 'px !important;'" because its value is used as number and it is yielding warning like
Notice: A non well formed numeric value encountered in /var/www/web/app/plugins/crayon-syntax-highlighter/crayon_formatter.class.php on line 118
Line 118: $toolbar_height = $font_size * 1.5 . 'px !important;';
So "$font_size" should not have the string 'px !important;' but it should have only number
And this string is added in different lines, so removing string from $font_size should be O.K.