fix: document processor and provider interface - #8446
Open
VincentLanglet wants to merge 1 commit into
Open
Conversation
VincentLanglet
force-pushed
the
phpdocs
branch
from
August 11, 2026 10:36
eb49ed2 to
5035082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @soyuka
The DeserializeProvider is throwing multiple exceptions.
But when writing
we end up with a dead catch from PHPStan thinking the service/interface is throwing nothing.
Looking at other provider, lot of them are throwing exceptions. Same for processor.
So I think it's better to document it can throw, promoting usage of try/catch if wanted.
Ci is already failing ; but this PR is only about phpdoc