Skip to content

[SYSTEMDS-3949] Extend Delta Spark round trip tests - #2580

Merged
Baunsgaard merged 1 commit into
apache:mainfrom
Jakob-al28:delta-spark-roundtrip-tests
Aug 6, 2026
Merged

[SYSTEMDS-3949] Extend Delta Spark round trip tests#2580
Baunsgaard merged 1 commit into
apache:mainfrom
Jakob-al28:delta-spark-roundtrip-tests

Conversation

@Jakob-al28

Copy link
Copy Markdown
Contributor

The Spark round trip tests cover multi-file layouts, deletion vectors,
partitioning, column mapping and schema evolution. This adds three that were
missing: a log that has been checkpointed, a column type SystemDS cannot map,
and a table more than one engine has written to.

test covers
checkpointBackedHistoryRead a log that rolled into a parquet checkpoint, with a delete after it, so the snapshot comes from a checkpoint plus trailing commits
unsupportedColumnTypeRead DATE / TIMESTAMP / DECIMAL columns, which have no SystemDS value type and must be rejected by name before decoding
systemdsCreateSparkAppendRead SystemDS creates the table, Spark appends to it, so a mixed engine commit history still reads back as one table

Add three scenarios only an external engine can set up: a log that has rolled
into a parquet checkpoint with a delete after it, DATE/TIMESTAMP/DECIMAL
columns that have no SystemDS value type and must be rejected on the Delta
type and a table SystemDS creates that Spark then appends to. Also stop
countParquet from counting checkpoint files as data files.

@Baunsgaard Baunsgaard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it passes the CI tests we merge it.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.45%. Comparing base (af500c8) to head (233edbe).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2580      +/-   ##
============================================
- Coverage     71.61%   71.45%   -0.16%     
- Complexity    50352    50409      +57     
============================================
  Files          1626     1629       +3     
  Lines        194664   195331     +667     
  Branches      38007    38078      +71     
============================================
+ Hits         139408   139574     +166     
- Misses        44328    44836     +508     
+ Partials      10928    10921       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Baunsgaard
Baunsgaard merged commit 06993dc into apache:main Aug 6, 2026
47 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SystemDS PR Queue Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants