[SYSTEMDS-3958] Add XML options for sparse rewrites - #2579
Open
ywcb00 wants to merge 4 commits into
Open
Conversation
…rsity estimator NOTE: This option also enables the sparsity rewrites. This will be separated into an individual option soon. feat(main/hops/EstimationUtils.java): create static method to get the sparsity estimator by a given string identifier refactor(main/hops/rewrite/ProgramRewriter.java): separate the conditioned cases for enabling sparsity mm chain rewrites and transpose mm chain rewrites refactor(main/hops/OptimizerUtils.java): rename flag for enabling transpose mm chain rewrites chore(test/**): adapt to the changes above
…ng sparsity rewrites change sparsity estimator option from being the string identifier to the actual enumeration item refactor(main/hops/estim/EstimationUtils.java): add method to get estimator type from identifier string add method to obtain an estimator object directly chore(**): adapt to the above changes chore(test/functions/rewrite/RewriteMatrixMultChainOptSparseTest.java): adapt to separate CLI option for enabling sparsity rewrites
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
============================================
+ Coverage 71.44% 71.48% +0.03%
- Complexity 50406 50444 +38
============================================
Files 1629 1629
Lines 195331 195491 +160
Branches 38078 38114 +36
============================================
+ Hits 139561 139749 +188
+ Misses 44836 44796 -40
- Partials 10934 10946 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ywcb00
changed the title
…sity rewrites and for selecting the respective sparsity estimator fix(main/api/DMLOptions.java): revert adding the cli options for enabling sparsity rewrites and selecting the sparsity estimator fix(main/api/DMLScript.java): revert adding the cli options for enabling sparsity rewrites and selecting the sparsity estimator chore(main/hops/rewrite/ProgramRewriter.java): adapt to the changes above chore(test/RewriteMatrixMultChainOptSparseTest.java): rewrite the XML config file to enable the sparsity rewrites instead of setting the CLI option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the XML options for enabling rewrites based on sparsity estimates and for specifying the respective sparsity estimator. Additionally, this PR introduces the enumeration for the estimator type and renames the previous activation flag, which now only applies to transposition rewrites.