Consistent resource-bundle descriptor validation (#272) - #286
Open
elharo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272
Problem
validate()split bundle descriptors withStringUtils.split(artifactDescriptor, ":"),which collapses empty segments, while
downloadBundles()usedartifactDescriptor.split(":"), which preserves them. So a malformed descriptorsuch as
group:artifact::type(missing version) passedvalidate()and thenfailed later with a confusing resolution error, never showing the clear
validation message.
Fix
validate()now uses the samesplit(":")logic asdownloadBundles()andadditionally rejects descriptors where groupId, artifactId or version is empty
(e.g. a missing segment). Malformed descriptors now fail fast with the existing,
clear "resource bundle configured must specify..." message.
The reactor lookup in
downloadBundles()compares with a non-null receiver(
s[0].equals(p.getGroupId())), so it is already null-safe.Test
New unit test
testValidateRejectsDescriptorWithEmptySegment: configures aorg.example:dep::jardescriptor and assertsvalidate()throws the validationerror. Verified the test fails without the fix (
validate()let the descriptorthrough) and passes with it. Full
mvn verify -Prun-its(unit + failsafe ITs,spotless/checkstyle/RAT) passes.