Perf: hoist orderAfterMerge out of the parent-plugin loop (#271) - #285
Open
elharo wants to merge 1 commit into
Open
Perf: hoist orderAfterMerge out of the parent-plugin loop (#271)#285elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #271
Problem
ModelUtils.mergePluginLists()recomputedModelUtils.orderAfterMerge(...)andcalled
childContainer.setPlugins(results)/childContainer.flushPluginMap()on every iteration of the parent-plugin loop, even though the loop body
already accumulates the merged plugins into
assembledPlugins.orderAfterMergewalks both full plugin lists withresults.contains/indexOflinear scans, making the whole merge O(P³) in the worst case for P parent
plugins plus repeated plugin-map flushes. The ordering result is identical
whether computed once at the end or per-iteration.
Fix
Hoist
orderAfterMerge(...)+setPlugins/flushPluginMapout of the loop andcompute them once after the loop finishes, using the final
assembledPlugins.Testing
No new tests (performance-only change). All existing tests pass, including the
failsafe integration tests run with
-Prun-its(ITSupplementalArtifactexercises the supplemental-model merge that uses
mergePluginLists), plusspotless/checkstyle/RAT via
mvn verify.