Added link to github discussions in the latest minutes - #595
Conversation
|
@rawkintrevo @andrewmusselman The failing test appears to be some import issue in testing/test_overlap_measurement.py |
|
@guan404ming can you comment on this? (I think you touched test_overlap_measurement last). By that i mean, the test shouldn't have failed (or even run) for docs only changes. Also @krishna-dave206 you need to revert papers.md i think that was included by mistake (based on the title) |
|
I've submit the fix which is merged now. CI here would pass after rebase on main branch.
You're right. They python test should only run on change for python related file. I will open another PR for fixing ci pipeline. Thanks! |
|
@rawkintrevo I added some content in papers.md, then i added the github discussion link to minutes, so it got overwritten. The thing is I did two things:
|
|
OK, what you did to papers.md is wildly wrong, this PR is unmergable until that is reverted. Per the failling test, Wesley said in the mahout that he rebased and that fixed it, so try that. Papers.md is supposed to pick up content from the _papers directory, you blew all of that away. If you think it should be blown away and changed, open an issue and we can discuss. |
|
@rawkintrevo I just reverted the changes in website/papers.md I'm sorry for the previous code that. Now, changes are reverted and no conflict or run tests failed is there. You can review it now. I agree |
Forgot to add the GitHub discussions link last time, so added it