Skip to content

Added link to github discussions in the latest minutes - #595

Merged
krishna-dave206 merged 3 commits into
apache:mainfrom
krishna-dave206:other
Oct 31, 2025
Merged

Added link to github discussions in the latest minutes#595
krishna-dave206 merged 3 commits into
apache:mainfrom
krishna-dave206:other

Conversation

@krishna-dave206

Copy link
Copy Markdown
Member

Forgot to add the GitHub discussions link last time, so added it

@krishna-dave206

Copy link
Copy Markdown
Member Author

@rawkintrevo @andrewmusselman The failing test appears to be some import issue in testing/test_overlap_measurement.py

@rawkintrevo

rawkintrevo commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

@guan404ming can you comment on this? (I think you touched test_overlap_measurement last). By that i mean, the test shouldn't have failed (or even run) for docs only changes.

Also @krishna-dave206 you need to revert papers.md i think that was included by mistake (based on the title)

@guan404ming

guan404ming commented Oct 30, 2025

Copy link
Copy Markdown
Member

I've submit the fix which is merged now. CI here would pass after rebase on main branch.

By that i mean, the test shouldn't have failed (or even run) for docs only changes.

You're right. They python test should only run on change for python related file. I will open another PR for fixing ci pipeline. Thanks!

@krishna-dave206

Copy link
Copy Markdown
Member Author

@rawkintrevo I added some content in papers.md, then i added the github discussion link to minutes, so it got overwritten. The thing is I did two things:

  1. Added some content to papers.md
  2. Added github discussion link to latest minutes
    that's why the title shows something else. Do review papers.md, and let me know if there's something which shouldn't be there.

@rawkintrevo

Copy link
Copy Markdown
Contributor

OK, what you did to papers.md is wildly wrong, this PR is unmergable until that is reverted.

Per the failling test, Wesley said in the mahout that he rebased and that fixed it, so try that.

Papers.md is supposed to pick up content from the _papers directory, you blew all of that away. If you think it should be blown away and changed, open an issue and we can discuss.

@krishna-dave206

Copy link
Copy Markdown
Member Author

@rawkintrevo I just reverted the changes in website/papers.md I'm sorry for the previous code that. Now, changes are reverted and no conflict or run tests failed is there. You can review it now. I agree papers.md should continue to pick up content from _papers/. I’ll open a separate, focused PR that only adds the paper summaries.
Apologies again — thanks for the quick review and for pointing this out.

@krishna-dave206
krishna-dave206 merged commit 1e797f1 into apache:main Oct 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants