Fix Log4j1SyslogLayout builder javadoc attributes - #4239
Open
kalayciburak wants to merge 1 commit into
Open
Conversation
Remove copy-pasted includeNewLine/escapeNL docs from SyslogLayout and document the attributes this builder actually exposes. Fixes apache#4237 Signed-off-by: Burak KALAYCI <kalayciburak1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Log4j1SyslogLayout.Builderjavadoc listedincludeNewLineandescapeNL, which were copy-pasted fromorg.apache.logging.log4j.core.layout.SyslogLayoutand are not implemented on this layout.Changes
facility,facilityPrinting,header,messageLayout, andcharsetincludeNewLine/escapeNLare not supported on this layoutTest
toSerializable()Log4j1SyslogLayoutafter the edit (javadoc-only change)Fixes #4237