[Incubator-kie-issues#1619] Correctly manage execution of invalid models

[AthiraHari77]

Fixes #7039

In this PR, Decision models are validated to ensure correctness, and both valid and invalid decisions are identified and handled accordingly. In the event of an exception, a valid status is returned to reflect the error state accurately.

Thank you for submitting this pull request

NOTE!: Double-check the target branch for this PR.
The default is main so it will target Drools 8 / Kogito.

Ports If a forward-port or a backport is needed, paste the forward port PR here

• link

Issue: (please edit the GitHub Issues link if it exists)

• link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

• paste the link(s) from GitHub here
• link 2
• link 3 etc.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• for pull request and downstream checks

  • Push a new commit to the PR. An empty commit would be enough.

• for a full downstream build

  • for github actions job: add the label run_fdb

• for Jenkins PR check only

  • If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on Build Now button.

[yesamer]

@AthiraHari77 License header is still missing here

[AthiraHari77]

@yesamer I have updated here as well

[pibizza]

I would go for the more readable assertThatIllegalStateExceptionIsThrownBy(.... Consider this also in the other tests.

[AthiraHari77]

@pibizza Updated the test cases as specified

[pibizza]

This is fine. I would probably split the test file in two - one for normal cases and one for exceptional cases. the one for exceptional cases can greatly be simplified, becoming a single parametric test. We can do this later however.

[gitgabrio]

Hi @AthiraHari77
great job.
But TBH I'm surprised that this modification does not break any test, apparently, and now I'm wondering if there could be something else missing.
At the same time, as maybe mentioned in private, I was pretty sure that we would need to modify, somehow, the message creation to have a better structured information.
Last, we have to be sure that our TCK implementation will be adapted accordingly, because I'm pretty sure that this modification could break the current one.

[gitgabrio]

HI @AthiraHari77
Many thanks for the PR.
I'm only slightly concerned about this assertion.
The logic here is that

1. decisions could be decisionsId or decisionName (IINW)
2. if an error message contains one of them, then the decisions it relates to is "wrong"

I'm afraid there could be some cases where an error message contains the decisionId or decisionName, but that the error is not in the decision itself (e.g. another element that refer that decision)

[yesamer]

@gitgabrio @AthiraHari77 I ran the TCK tests against those changes, and there is only one new test failure:
1131 - feel -function invocation test: Non existing function evaluates to null (10.3.2.13.2)
I guess we should return null in case those errors occur.

[tiagobento]

Closing as stale.