Skip to content

fix(connectors): hand off SDK worker during blocking send callbacks #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlevkov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(connectors): hand off SDK worker during blocking send callbacks #3797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion core/connectors/sdk/src/source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,15 @@ async fn handle_messages<T: Source>(
}
};

callback(plugin_id, messages.as_ptr(), messages.len());
// The callback can block for backpressure (the runtime parks
// it while its bounded forwarding channel is full), and this
// task runs on the runtime shared by every instance loaded
// from this library. Hand the worker off so a saturated
// instance cannot pin it and stall a sibling's close, which
// waits on this task exiting.
tokio::task::block_in_place(|| {
callback(plugin_id, messages.as_ptr(), messages.len());
});
}
}
}
Expand Down
Loading