Skip to content

fix: Update release scripts to copy files into provision image rather than bind mount - #2719

Open
dannycjones wants to merge 2 commits into
apache:mainfrom
dannycjones:fix-provision-docker-mount
Open

fix: Update release scripts to copy files into provision image rather than bind mount#2719
dannycjones wants to merge 2 commits into
apache:mainfrom
dannycjones:fix-provision-docker-mount

Conversation

@dannycjones

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

N/A

What changes are included in this PR?

When running on a system that uses a VM to run containers, such as Colima on macOS, not all local directories may be available to the VM the container runtime. For Colima, it only mounts the home directory within the VM and thus files in the home directory (common case) can be successfully bind-mounted into the containers, this will break where we use temporary directories in the release scripts.

This change avoids the dependency on bind mounting the temporary directory by copying the Spark script into a built image for the provisioner image.

This does not address all issues on macOS as HMS does not have an ARM-based image (leading to apparent dreadful runtime due to emulation), however this eliminates one problem. If we move to a HMS v4+ in the future, this change gets us closer to reliable release candidate verification on macOS.

Are these changes tested?

Yes, changes have been tested locally by bringing up the containers and running the tests.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jul 27, 2026
@dannycjones

Copy link
Copy Markdown
Contributor Author

I think this is a useful improvement to the release scripts, this should remain open for review.

@github-actions github-actions Bot removed the stale label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant