BIGTOP-4545. hbase: versionless jar symlinks broken for version strings with extra "-<digit>" suffix#1405
Merged
Conversation
…gs with extra "-<digit>" suffix
iwasakims
approved these changes
Jul 27, 2026
iwasakims
left a comment
Member
There was a problem hiding this comment.
The change affects following files pulled from hbase-thirdparty too. I guess linking them was not intended by the original author. Let's see if existing tests are happy by merging this.
hbase-shaded-jackson-jaxrs-json-provider-4.1.13.jar
hbase-shaded-jersey-4.1.13.jar
hbase-shaded-jetty-4.1.13.jar
hbase-shaded-miscellaneous-4.1.13.jar
hbase-shaded-netty-4.1.13.jar
hbase-shaded-netty-tcnative-4.1.13.jar
hbase-shaded-protobuf-4.1.13.jar
hbase-unsafe-4.1.13.jar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The hbase RPM creates versionless symlinks for jars using a sed pattern:
The greedy (.*) makes the pattern strip only from the last "-" occurrence. This breaks for version strings that contain an additional "-" segment, e.g. a downstream/vendor version like 2.6.5-custom-1:
The expected link name is hbase-common.jar, but hbase-common-2.6.5-custom.jar is created instead.
Fix: match against the known HBASE_VERSION explicitly instead of guessing where the version starts:
How was this patch tested?
For code changes: