Skip to content

Fix Flink runner tests on Java 21#39272

Open
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix/flink-java21-tests
Open

Fix Flink runner tests on Java 21#39272
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix/flink-java21-tests

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes: #39252
Successful run: https://github.com/apache/beam/actions/runs/29061791187

After switching to Java 21, Flink runner tests started failing in PreCommit Java

The main problems were:

  • Flink/Kryo tests needed extra JVM --add-opens flags on Java 21
  • FlinkSubmissionTest used old reflection tricks that do not work on newer Java (Field.modifiers, wrong env map update)
  • System.setSecurityManager() needs -Djava.security.manager=allow on Java 21
  • On Linux , modifyEnv() was putting plain String keys into ProcessEnvironment.theEnvironment, but that map uses Variable/Value keys, so FLINK_CONF_DIR was not visible and tests timed out waiting for jobs

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@aIbrahiim aIbrahiim force-pushed the fix/flink-java21-tests branch from 1997f42 to 4b56a2b Compare July 10, 2026 08:46
@aIbrahiim aIbrahiim marked this pull request as ready for review July 10, 2026 08:49
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues that arose when migrating Flink runner tests to Java 21. The changes primarily focus on updating JVM arguments, modernizing reflection-based environment variable manipulation to account for internal JDK changes, and improving the robustness of existing test assertions to prevent timeouts.

Highlights

  • Java 21 Compatibility: Updated Flink runner tests to include necessary JVM --add-opens flags and enabled the security manager via -Djava.security.manager=allow.
  • Environment Variable Handling: Refactored modifyEnv in FlinkSubmissionTest to correctly handle ProcessEnvironment map types on Unix, ensuring FLINK_CONF_DIR is properly visible to Flink.
  • Test Stability: Improved test reliability in UnboundedSourceWrapperTest by replacing infinite loops with timed deadlines and more robust stack trace inspection.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates FlinkSubmissionTest to correctly modify environment variables across different operating systems (Unix and Windows) by reflecting on internal JVM ProcessEnvironment maps. It also configures necessary JVM arguments for Flink tests when running on Java 17 or higher, and replaces an infinite loop in UnboundedSourceWrapperTest with a timed loop to prevent test hangs. The reviewer suggests using System.nanoTime() instead of System.currentTimeMillis() in UnboundedSourceWrapperTest to measure the timeout monotonically, avoiding issues with system clock adjustments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +668 to +670
long deadlineMs = System.currentTimeMillis() + 9_000;
boolean reachedFinalizeSource = false;
while (System.currentTimeMillis() < deadlineMs) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using System.currentTimeMillis() to measure elapsed time or timeouts is an anti-pattern because it is sensitive to system clock adjustments (such as NTP synchronization or manual clock changes). It is highly recommended to use System.nanoTime() for monotonic time measurements instead.

Suggested change
long deadlineMs = System.currentTimeMillis() + 9_000;
boolean reachedFinalizeSource = false;
while (System.currentTimeMillis() < deadlineMs) {
long deadlineNs = System.nanoTime() + 9_000_000_000L;
boolean reachedFinalizeSource = false;
while (System.nanoTime() < deadlineNs) {

@aIbrahiim aIbrahiim force-pushed the fix/flink-java21-tests branch from 4b56a2b to 2f31a3d Compare July 10, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Java job is flaky

1 participant